NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

chore: rename 'tools/functional/' to 'tests/functional/'#1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/test_directory

May 26, 2021

Merged

chore: rename 'tools/functional/' to 'tests/functional/'#1469

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/test_directory

May 26, 2021

Conversation

Copy link

Member

JohnVillalovos commentedMay 26, 2021

Rename the 'tools/functional/' directory to 'tests/functional/'

This makes more sense as these are functional tests and not tools.

JohnVillalovos marked this pull request as draft

May 26, 2021 00:36

JohnVillalovos requested a review fromnejch

May 26, 2021 00:47

JohnVillalovos marked this pull request as ready for review

May 26, 2021 00:47

Copy link

codecov-commenter commentedMay 26, 2021•
edited
Loading

Codecov Report

Merging#1469 (502715d) intomaster (9beff0d) willdecrease coverage by8.91%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master    #1469      +/-   ##==========================================- Coverage   90.91%   82.00%   -8.92%==========================================  Files          73       73                Lines        4051     4051              ==========================================- Hits         3683     3322     -361- Misses        368      729     +361

Flag	Coverage Δ
cli_func_v4	`?`
py_func_v4	`?`
unit	`82.00% <ø> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/v4/objects/files.py	`52.94% <0.00%> (-39.71%)`	⬇️
gitlab/v4/cli.py	`41.63% <0.00%> (-39.69%)`	⬇️
gitlab/v4/objects/milestones.py	`71.42% <0.00%> (-28.58%)`	⬇️
gitlab/v4/objects/labels.py	`65.21% <0.00%> (-28.27%)`	⬇️
gitlab/cli.py	`60.00% <0.00%> (-26.09%)`	⬇️
gitlab/v4/objects/tags.py	`63.88% <0.00%> (-25.00%)`	⬇️
gitlab/utils.py	`65.51% <0.00%> (-24.14%)`	⬇️
gitlab/v4/objects/repositories.py	`57.62% <0.00%> (-23.73%)`	⬇️
gitlab/v4/objects/settings.py	`73.68% <0.00%> (-21.06%)`	⬇️
gitlab/v4/objects/sidekiq.py	`80.95% <0.00%> (-19.05%)`	⬇️
... and16 more

nejch requested changes

May 26, 2021

View reviewed changes

Copy link

Member

nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks John! Could you also change the paths in the renovate config:

python-gitlab/.renovaterc.json

Line 7 ineabe091

"fileMatch": ["^tools/functional/fixtures/.env$"],

And the Manifest (especially if we move unit tests there also):

python-gitlab/MANIFEST.in

Line 3 ineabe091

recursive-include tools *

chore: rename 'tools/functional/' to 'tests/functional/'

502715d

Rename the 'tools/functional/' directory to 'tests/functional/'This makes more sense as these are functional tests and not tools.This was dicussed in:#1468

Copy link

MemberAuthor

JohnVillalovos commentedMay 26, 2021

Thanks John! Could you also change the paths in the renovate config:
python-gitlab/.renovaterc.json
Line 7 ineabe091
"fileMatch": ["^tools/functional/fixtures/.env$"],
And the Manifest (especially if we move unit tests there also):
python-gitlab/MANIFEST.in
Line 3 ineabe091
recursive-include tools *