Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add isort as a checker#1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 2 commits intopython-gitlab:masterfromJohnVillalovos:jlvillal/isort
May 25, 2021
Merged

chore: add isort as a checker#1463

nejch merged 2 commits intopython-gitlab:masterfromJohnVillalovos:jlvillal/isort
May 25, 2021

Conversation

JohnVillalovos
Copy link
Member

isort is a tool to make sure that imports are ordered correctly.

Add a tox environment for it and also add it to the Github workflow to
ensure it is checked for Pull Requests.

Run isort on all the code and commit changes it made.

https://pycqa.github.io/isort/

nejch reacted with thumbs up emoji
@codecov-commenter
Copy link

codecov-commenter commentedMay 22, 2021•
edited
Loading

Codecov Report

Merging#1463 (4a505df) intomaster (1508eb7) willincrease coverage by0.02%.
The diff coverage is98.14%.

❗ Current head4a505df differs from pull request most recent head4cfd7b7. Consider uploading reports for the commit4cfd7b7 to get more accurate results

@@            Coverage Diff             @@##           master    #1463      +/-   ##==========================================+ Coverage   90.83%   90.85%   +0.02%==========================================  Files          73       73                Lines        4027     4037      +10     ==========================================+ Hits         3658     3668      +10  Misses        369      369
FlagCoverage Δ
cli_func_v480.40% <98.14%> (+0.04%)⬆️
py_func_v479.48% <96.29%> (+0.05%)⬆️
unit81.94% <98.14%> (+0.04%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/__main__.py0.00% <ø> (ø)
gitlab/const.py100.00% <ø> (ø)
gitlab/v4/objects/access_requests.py100.00% <ø> (ø)
gitlab/v4/objects/appearance.py100.00% <ø> (ø)
gitlab/v4/objects/award_emojis.py100.00% <ø> (ø)
gitlab/v4/objects/badges.py100.00% <ø> (ø)
gitlab/v4/objects/boards.py100.00% <ø> (ø)
gitlab/v4/objects/branches.py73.52% <ø> (ø)
gitlab/v4/objects/broadcast_messages.py100.00% <ø> (ø)
gitlab/v4/objects/container_registry.py83.33% <ø> (ø)
... and57 more

@JohnVillalovosJohnVillalovos changed the titleAdd isort as a checkerchore: add isort as a checkerMay 22, 2021
  * Add an isort tox environment  * Run the isort tox environment using --check in the Github CIhttps://pycqa.github.io/isort/
@JohnVillalovosJohnVillalovos self-assigned thisMay 22, 2021
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, finally don't need to worry about whether the first 10 lines in new files make sense 😁 Just have a few thoughts.

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome! Thanks again :)

@nejchnejch merged commit7824811 intopython-gitlab:masterMay 25, 2021
@JohnVillalovosJohnVillalovos deleted the jlvillal/isort branchMay 26, 2021 00:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees

@JohnVillalovosJohnVillalovos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp