Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(objects): add support for generic packages API#1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JohnVillalovos merged 2 commits intomasterfromfeat/generic-packages
Jun 1, 2021

Conversation

nejch
Copy link
Member

@nejchnejch commentedMay 16, 2021
edited
Loading

Closes#1389.

I had to add araw param to put/post like we have for get, instead of usingfiles with the multipart encoder, to really ensure only the raw data ended up as the uploaded package 🤔

Maybe it's just howfiles are handled currently and can still be refactored to take out redundant stuff if we want a raw upload. In the meantime I also cleaned out some code fromhttp_request into a helper method and centralized the content_types there (http_request would be getting quite long and messy otherwise).

@codecov-commenter
Copy link

codecov-commenter commentedMay 16, 2021
edited
Loading

Codecov Report

Merging#1460 (64e8d57) intomaster (fb7174e) willincrease coverage by0.08%.
The diff coverage is91.30%.

@@            Coverage Diff             @@##           master    #1460      +/-   ##==========================================+ Coverage   90.92%   91.01%   +0.08%==========================================  Files          73       73                Lines        4056     4107      +51     ==========================================+ Hits         3688     3738      +50- Misses        368      369       +1
FlagCoverage Δ
cli_func_v480.71% <89.13%> (+0.21%)⬆️
py_func_v480.05% <91.30%> (+0.20%)⬆️
unit82.20% <91.30%> (+0.17%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/client.py86.60% <87.50%> (-0.04%)⬇️
gitlab/v4/objects/packages.py96.15% <93.10%> (-3.85%)⬇️
gitlab/v4/objects/projects.py83.48% <100.00%> (ø)
gitlab/v4/objects/statistics.py100.00% <0.00%> (ø)
gitlab/v4/objects/deployments.py100.00% <0.00%> (ø)
gitlab/v4/cli.py81.56% <0.00%> (+0.39%)⬆️
gitlab/v4/objects/merge_requests.py82.75% <0.00%> (+0.77%)⬆️
gitlab/v4/objects/groups.py83.50% <0.00%> (+1.08%)⬆️

@nejchnejchforce-pushed thefeat/generic-packages branch from0af668f tofadc681CompareMay 29, 2021 22:07
@nejchnejchforce-pushed thefeat/generic-packages branch fromfadc681 to9b4cc2cCompareMay 30, 2021 04:09
Co-authored-by: John Villalovos <john@sodarock.com>
@nejchnejchforce-pushed thefeat/generic-packages branch from0c271b7 to64e8d57CompareMay 31, 2021 22:40
Copy link
MemberAuthor

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! :) I've applied all the typing suggestions, for enforcing keyword arguments we can maybe discuss separately

Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks!

@JohnVillalovosJohnVillalovos merged commita11623b intomasterJun 1, 2021
@JohnVillalovosJohnVillalovos deleted the feat/generic-packages branchJune 1, 2021 03:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFE: Add support to upload generic package
3 participants
@nejch@codecov-commenter@JohnVillalovos

[8]ページ先頭

©2009-2025 Movatter.jp