- Notifications
You must be signed in to change notification settings - Fork673
feat(objects): add support for generic packages API#1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedMay 16, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1460 +/- ##==========================================+ Coverage 90.92% 91.01% +0.08%========================================== Files 73 73 Lines 4056 4107 +51 ==========================================+ Hits 3688 3738 +50- Misses 368 369 +1
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: John Villalovos <john@sodarock.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! :) I've applied all the typing suggestions, for enforcing keyword arguments we can maybe discuss separately
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks!
Uh oh!
There was an error while loading.Please reload this page.
Closes#1389.
I had to add a
raw
param to put/post like we have for get, instead of usingfiles
with the multipart encoder, to really ensure only the raw data ended up as the uploaded package 🤔Maybe it's just how
files
are handled currently and can still be refactored to take out redundant stuff if we want a raw upload. In the meantime I also cleaned out some code fromhttp_request
into a helper method and centralized the content_types there (http_request
would be getting quite long and messy otherwise).