NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

fix(base): allow persisting local attributes when updating object#1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

nejch wants to merge1 commit intomasterfromfix/persist-attributes-on-save

Closed

fix(base): allow persisting local attributes when updating object#1443

nejch wants to merge1 commit intomasterfromfix/persist-attributes-on-save

Conversation

Copy link

Member

nejch commentedMay 2, 2021

Related to#1395.

fix(base): allow persisting attributes when updating object

796c700

Copy link

codecov-commenter commentedMay 2, 2021

Codecov Report

Merging#1443 (796c700) intomaster (b563cdc) willincrease coverage by0.00%.
The diff coverage is81.81%.

@@           Coverage Diff           @@##           master    #1443   +/-   ##=======================================  Coverage   80.24%   80.24%           =======================================  Files          73       73             Lines        4064     4081   +17     =======================================+ Hits         3261     3275   +14- Misses        803      806    +3

Flag	Coverage Δ
unit	`80.24% <81.81%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/mixins.py	`77.13% <66.66%> (-0.25%)`	⬇️
gitlab/base.py	`88.88% <100.00%> (+0.28%)`	⬆️
gitlab/types.py	`90.00% <0.00%> (-2.60%)`	⬇️
gitlab/exceptions.py	`96.52% <0.00%> (-1.30%)`	⬇️
gitlab/__main__.py	`0.00% <0.00%> (ø)`
gitlab/cli.py	`56.36% <0.00%> (+2.30%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb563cdc...796c700. Read thecomment docs.

nejch mentioned this pull request

May 2, 2021

Objects lose their custom_attributes during a save()#1395

Closed

Copy link

Member

max-wittig commentedMay 3, 2021

I'm not sure, if this makes sense.python-gitlab should be a light wrapper around the GitLab API. If we start adding more custom things (other than the required ones e.g.lazy) that might become less maintainable and maybe also confusing for the users? WDYT?