- Notifications
You must be signed in to change notification settings - Fork673
chore(docs): fix import order for readthedocs build#1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedMay 1, 2021
Codecov Report
@@ Coverage Diff @@## master #1442 +/- ##======================================= Coverage 80.24% 80.24% ======================================= Files 73 73 Lines 4064 4064 ======================================= Hits 3261 3261 Misses 803 803
Flags with carried forward coverage won't be shown.Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense. Thanks for catching this!
This partially revertsb498ebd. I noticed the builds are failing on RTD right now and it started with this commit.
Turns out RTD does not have
gitlabin path because it does its own weird build, so we really need this hack. Here's requests doing the same:https://github.com/psf/requests/blob/c45a4dfe6bfc6017d4ea7e9f051d6cc30972b310/docs/conf.py#L23-L27There might be cleaner solutions but if
psfrepos do it, I guess this is ok 🤣