- Notifications
You must be signed in to change notification settings - Fork673
docs: fail on warnings during sphinx build#1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is useful when docs aren't included in the toctree and don't show up on RTD.
codecov-commenter commentedMay 1, 2021
Codecov Report
@@ Coverage Diff @@## master #1441 +/- ##======================================= Coverage 80.24% 80.24% ======================================= Files 73 73 Lines 4064 4064 ======================================= Hits 3261 3261 Misses 803 803
Flags with carried forward coverage won't be shown.Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like being strict.
LGTM and Thanks!
I was hesitant to make it this strict first, but realized this is useful when docs aren't included in the toctree and the articles don't show up on RTD, unless users specifically search for those keywords. So we actually had some dead documentation this whole time.
Closes#1370.