- Notifications
You must be signed in to change notification settings - Fork674
feat: add code owner approval as attribute#1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: add code owner approval as attribute#1437
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The python API was missing the field code_owner_approval_requiredas implemented in the GitLab REST API.
JohnVillalovos commentedMay 1, 2021
A test for this would be awesome. Maybe in the functional tests. For an example see:https://github.com/python-gitlab/python-gitlab/blob/master/tools/functional/api/test_projects.py#L190 |
codecov-commenter commentedMay 1, 2021
Codecov Report
@@ Coverage Diff @@## master #1437 +/- ##======================================= Coverage 80.24% 80.24% ======================================= Files 73 73 Lines 4064 4064 ======================================= Hits 3261 3261 Misses 803 803
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
nejch commentedMay 1, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@JohnVillalovos in this case I think we won't be able to test it in functional tests, as it's a premium feature and our CE docker container won't return the attribute. Edit: I'll merge this for now John, as writing tests for all attributes would get tedious unless we need to test something specific around their behavior (like our list issue), but we should definitely think about how to maintain these hardcoded attributes better. Since GitLab doesn't have an OpenAPI spec, maybe by periodically scanning the markdown tables from their docs for required/optional args for all endpoints and checking against our tuples, lol |
Uh oh!
There was an error while loading.Please reload this page.
Add
ProjectProtectedBranchManager.code_owner_approval_requiredto mimickGitLab API documentation:Fixes#1436