- Notifications
You must be signed in to change notification settings - Fork673
chore(ci): automate releases#1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedApr 28, 2021
Codecov Report
@@ Coverage Diff @@## master #1427 +/- ##======================================= Coverage 80.24% 80.24% ======================================= Files 73 73 Lines 4064 4064 ======================================= Hits 3261 3261 Misses 803 803
Flags with carried forward coverage won't be shown.Click here to find out more. Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading.Please reload this page.
Often it's not really required to release every week. Gitlab releases every month. Maybe that makes more sense? To release shortly after Gitlab's monthly release? |
Ok, makes sense 👍 Originally I was thinking so that people don't have to wait after things get merged as they are sometimes asking in PRs, but it might get too spammy for others like that. I'll change the cron for the end of the month. |
I've reworded this and made the cron schedule to be on the 28th of the month, that should give us a few days after the 22nd to add some popular features after a GitLab release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks
Uh oh!
There was an error while loading.Please reload this page.
Adds an automated release
every weekonce a month + manual workflow if quick fixes are needed. I thought this would be a good compromise. I didn't want this on every push as otherwise all release notes just have only 1 PR entry and it's just really noisy. I see other people are also reconsidering that:renovatebot/renovate#9709.Also I just chose Monday so there's no Friday releases 🤣 but open to suggestions.
I tested this here (including all my derpy trial&error pushes):
https://github.com/nejch/python-gitlab-semantic-release
Resulting releases:https://github.com/nejch/python-gitlab-semantic-release/releases
testpypi package:https://test.pypi.org/project/python-gitlab/
changelog:https://github.com/nejch/python-gitlab-semantic-release/blob/master/CHANGELOG.md
I've also already set up the
PYPI_TOKENsecret here.Initially I wasn't a fan of the auto-committed
CHANGELOG.mdbut now I'm thinking it gives us a chance to consolidate the old changelog and release notes that are just sitting there since the GH Releases move. I can push another PR for that to add the old changes it to the new changelog.