Codecov Report

Merging#1421 (e4421ca) intomaster (a6b6cd4) willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #1421   +/-   ##=======================================  Coverage   80.24%   80.24%           =======================================  Files          73       73             Lines        4064     4064           =======================================  Hits         3261     3261             Misses        803      803

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea6b6cd4...e4421ca. Read thecomment docs.

question: does this mean we should probably do in.mypy.ini:

[mypy]files = gitlab/**/*.py

So that we check this recursively with mypy aspy.typed applies recursively, just in case.

Currently, this fails because of unit tests, but I've long thought we should unit and functional tests together, outside the source dir. (e.g.tools/functional ->tests/functional,gitlab/tests ->tests/unit)

I would like to wait on saying we mypy check everything. As I don't think we are ready.

This PR in my mind is just saying we do have type-hints so someone can use them. Alsomypy will see that file and then not complain that there aren't type-hints. For example for a user of the library:

import gitlab      # With the PR mypy won't complain about no type-hints

Do we have type-hints for everything? No, but progress is being made and the type-hints we have are useful already and can be used by users of this library to help type-hint their code.

Ok makes sense :) Thanks!