- Notifications
You must be signed in to change notification settings - Fork673
Fix JIRA service - add api_url to mandatory attributes#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The api_url attribute is mandatory at least since GitLab 8.11.Otherwise server returns gitlab.exceptions.GitlabUpdateError: 400: 400 (Bad request) "api_url" not given.
Thank you for the patch. I'd rather define this parameter as optional, to keep compatibility with older versions of Gitlab. I know it's not optimal but I don't have a solution to handle multiple APIs in multiple Gitlab versions at the moment. |
@gpocentek sounds good to me. Closing this pull request. Thanks! |
@galet you can update this pull request if you still want to submit the change. |
- move api_url to optional attributes based on comments inpython-gitlab#142 (comment)
Created a new clean pull request#146. |
The
api_urlattribute is mandatory at least since GitLab 8.11. Otherwise server returnsgitlab.exceptions.GitlabUpdateError: 400: 400 (Bad request) "api_url" not given.