- Notifications
You must be signed in to change notification settings - Fork673
feat: add support for lists of integers to ListAttribute#1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: add support for lists of integers to ListAttribute#1415
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Previously ListAttribute only support lists of integers. Now be moreflexible and support lists of items which can be coerced into strings,for example integers.This will help us fix issue#1407 by using ListAttribute for the'iids' field.
codecov-commenter commentedApr 25, 2021
Codecov Report
@@ Coverage Diff @@## master #1415 +/- ##======================================= Coverage 80.18% 80.18% ======================================= Files 73 73 Lines 4063 4063 ======================================= Hits 3258 3258 Misses 805 805
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it's a good idea to merge this first :) later when it comes to individual endpoints it might be good to add int. tests for those to see how gitlab behaves.
Previously ListAttribute only support lists of integers. Now be more
flexible and support lists of items which can be coerced into strings,
for example integers.
This will help us fix issue#1407 by using ListAttribute for the
'iids' field.