Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(objects): remove noisy deprecation warning for audit events#1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
max-wittig merged 1 commit intomasterfromchore/remove-noisy-deprecation-warning
Apr 25, 2021

Conversation

nejch
Copy link
Member

When I added this in#1363 I missed that it always gets instantiated and everyone will be getting the warning. It's mostly an internal thing anyway and can be removed in 3.0.0.

Needed for 2.7.0#1408 so people don't get spammed 😁

@codecov-commenter
Copy link

codecov-commenter commentedApr 25, 2021•
edited
Loading

Codecov Report

Merging#1414 (2953642) intomaster (4f79dff) willdecrease coverage by0.02%.
The diff coverage is100.00%.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1414      +/-   ##==========================================- Coverage   80.20%   80.17%   -0.03%==========================================  Files          73       73                Lines        4067     4061       -6     ==========================================- Hits         3262     3256       -6  Misses        805      805
FlagCoverage Δ
unit80.17% <100.00%> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/audit_events.py100.00% <ø> (ø)
gitlab/client.py78.96% <100.00%> (-0.06%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatecfc42d2...2953642. Read thecomment docs.

It's mostly an internal thing anyway and can be removed in 3.0.0
@nejchnejchforce-pushed thechore/remove-noisy-deprecation-warning branch from5453c60 to2953642CompareApril 25, 2021 12:31
@nejchnejch mentioned this pull requestApr 25, 2021
@max-wittigmax-wittig merged commit0a0fcaf intomasterApr 25, 2021
@nejchnejch deleted the chore/remove-noisy-deprecation-warning branchMay 30, 2021 08:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@max-wittigmax-wittig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@nejch@codecov-commenter@max-wittig
[8]ページ先頭
©2009-2025 Movatter.jp