Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: make Get.*Mixin._optional_get_attrs always present#1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/optional_get_attrs
Apr 26, 2021
Merged

chore: make Get.*Mixin._optional_get_attrs always present#1412

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/optional_get_attrs
Apr 26, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedApr 24, 2021•
edited
Loading

Always create GetMixin/GetWithoutIdMixin._optional_get_attrs attribute
with a default value of tuple()

This way we don't need to use hasattr() and we will know the type of
the attribute.

@JohnVillalovosJohnVillalovos marked this pull request as draftApril 24, 2021 19:54
Always create GetMixin/GetWithoutIdMixin._optional_get_attrs attributewith a default value of tuple()This way we don't need to use hasattr() and we will know the type ofthe attribute.
@codecov-commenter
Copy link

Codecov Report

Merging#1412 (3c1a0b3) intomaster (4f79dff) willincrease coverage by0.00%.
The diff coverage is100.00%.

Impacted file tree graph

@@           Coverage Diff           @@##           master    #1412   +/-   ##=======================================  Coverage   80.20%   80.21%           =======================================  Files          73       73             Lines        4067     4068    +1     =======================================+ Hits         3262     3263    +1  Misses        805      805
FlagCoverage Δ
unit80.21% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/client.py78.96% <100.00%> (-0.06%)⬇️
gitlab/mixins.py77.32% <100.00%> (+0.10%)⬆️
gitlab/v4/cli.py41.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatecfc42d2...3c1a0b3. Read thecomment docs.

@JohnVillalovosJohnVillalovos changed the titlechore: make GetMixin._optional_get_attrs always presentchore: make Get.*Mixin._optional_get_attrs always presentApr 24, 2021
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewApril 24, 2021 20:03
@nejchnejch merged commit5b81d7d intopython-gitlab:masterApr 26, 2021
@JohnVillalovosJohnVillalovos deleted the jlvillal/optional_get_attrs branchJanuary 4, 2022 06:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp