- Notifications
You must be signed in to change notification settings - Fork675
chore: make ListMixin._list_filters always present#1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: make ListMixin._list_filters always present#1411
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Always create ListMixin._list_filters attribute with a default valueof tuple().This way we don't need to use hasattr() and we will know the type ofthe attribute.
codecov-commenter commentedApr 24, 2021
Codecov Report
@@ Coverage Diff @@## master #1411 +/- ##======================================= Coverage 80.20% 80.20% ======================================= Files 73 73 Lines 4067 4067 ======================================= Hits 3262 3262 Misses 805 805
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
Always create ListMixin._list_filters attribute with a default value
of tuple().
This way we don't need to use hasattr() and we will know the type of
the attribute.