NotificationsYou must be signed in to change notification settings
Fork674
Star2.4k

chore: make RESTObject._short_print_attrs always present#1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/short_print_attr

Apr 25, 2021

Merged

chore: make RESTObject._short_print_attrs always present#1410

max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/short_print_attr

Apr 25, 2021

Conversation

Copy link

Member

JohnVillalovos commentedApr 24, 2021

Always create RESTObject._short_print_attrs with a default value of
None.

This way we don't need to use hasattr() and we will know the type of
the attribute.

chore: make RESTObject._short_print_attrs always present

6d55120

Always create RESTObject._short_print_attrs with a default value ofNone.This way we don't need to use hasattr() and we will know the type ofthe attribute.

Copy link

codecov-commenter commentedApr 24, 2021

Codecov Report

Merging#1410 (6d55120) intomaster (4f79dff) willnot change coverage.
The diff coverage is83.33%.

@@           Coverage Diff           @@##           master    #1410   +/-   ##=======================================  Coverage   80.20%   80.20%           =======================================  Files          73       73             Lines        4067     4067           =======================================  Hits         3262     3262             Misses        805      805

Flag	Coverage Δ
unit	`80.20% <83.33%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/v4/cli.py	`41.63% <0.00%> (ø)`
gitlab/base.py	`88.60% <100.00%> (+0.07%)`	⬆️
gitlab/client.py	`78.96% <100.00%> (-0.06%)`	⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatecfc42d2...6d55120. Read thecomment docs.