Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: mypy: Disallow untyped definitions#1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/untyped_defs
May 1, 2021
Merged

chore: mypy: Disallow untyped definitions#1409

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/untyped_defs
May 1, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedApr 24, 2021•
edited
Loading

Be more strict and don't allow untyped definitions on the files we
check.

Also this adds type-hints for two of the decorators so that now
functions/methods decorated by them will have their types be revealed
correctly.

@codecov-commenter
Copy link

codecov-commenter commentedApr 24, 2021•
edited
Loading

Codecov Report

Merging#1409 (6aef2da) intomaster (a6b6cd4) willincrease coverage by0.01%.
The diff coverage is74.50%.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1409      +/-   ##==========================================+ Coverage   80.24%   80.26%   +0.01%==========================================  Files          73       73                Lines        4064     4073       +9     ==========================================+ Hits         3261     3269       +8- Misses        803      804       +1
FlagCoverage Δ
unit80.26% <74.50%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/__main__.py0.00% <0.00%> (ø)
gitlab/cli.py56.36% <55.55%> (+2.30%)⬆️
gitlab/exceptions.py96.52% <83.33%> (-1.30%)⬇️
gitlab/types.py90.00% <91.66%> (-2.60%)⬇️
gitlab/base.py88.60% <100.00%> (ø)
gitlab/config.py92.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea6b6cd4...6aef2da. Read thecomment docs.

@JohnVillalovosJohnVillalovos changed the titlemypy: Disallow untyped definitionschore: mypy: Disallow untyped definitionsApr 24, 2021
@max-wittig
Copy link
Member

Just a small question

@JohnVillalovos
Copy link
MemberAuthor

Just a small question

@max-wittig I think I answered your question, but let me know if you need more information.

Thanks

Be more strict and don't allow untyped definitions on the files wecheck.Also this adds type-hints for two of the decorators so that nowfunctions/methods decorated by them will have their types be revealedcorrectly.
@nejchnejch merged commit562fbbd intopython-gitlab:masterMay 1, 2021
@JohnVillalovosJohnVillalovos deleted the jlvillal/untyped_defs branchJanuary 4, 2022 06:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@max-wittigmax-wittigmax-wittig left review comments

@nejchnejchnejch approved these changes

Assignees

@JohnVillalovosJohnVillalovos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@JohnVillalovos@codecov-commenter@max-wittig@nejch
[8]ページ先頭
©2009-2025 Movatter.jp