- Notifications
You must be signed in to change notification settings - Fork674
fix: update user's bool data and avatar#1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
max-wittig merged 1 commit intopython-gitlab:masterfromDylannCordel:fix-upd-user-bool-data-and-avatarApr 23, 2021
Merged
fix: update user's bool data and avatar#1404
max-wittig merged 1 commit intopython-gitlab:masterfromDylannCordel:fix-upd-user-bool-data-and-avatarApr 23, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If we want to update email, avatar and do not send emailconfirmation change (`skip_reconfirmation` = True), `MultipartEncoder`will try to encode everything except None and bytes. So it tries to encode bools.Casting bool's values to their stringified int representation fix it.
JohnVillalovos approved these changesApr 23, 2021
Member
JohnVillalovos left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense to me.
Thanks
Member
max-wittig commentedApr 23, 2021
Thanks LGTM 👍 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
If we want to update email, avatar and do not send email confirmation change (
skip_reconfirmation= True),MultipartEncoderwill try to encode everything except None and bytes. So it tries to encode bools.Casting bool's values to their stringified int representation fix it.
Exemple to reproduce it: