NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

fix: argument type was not a tuple as expected#1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/fix_custom_action

Apr 19, 2021

Merged

fix: argument type was not a tuple as expected#1399

max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/fix_custom_action

Apr 19, 2021

Conversation

Copy link

Member

JohnVillalovos commentedApr 18, 2021

While adding type-hints mypy flagged this as an issue. The third
argument to register_custom_action is supposed to be a tuple. It was
being passed as a string rather than a tuple of strings.

fix: argument type was not a tuple as expected

062f8f6

While adding type-hints mypy flagged this as an issue. The thirdargument to register_custom_action is supposed to be a tuple. It wasbeing passed as a string rather than a tuple of strings.

Copy link

codecov-commenter commentedApr 18, 2021

Codecov Report

Merging#1399 (062f8f6) intomaster (916a7fe) willnot change coverage.
The diff coverage is100.00%.

@@           Coverage Diff           @@##           master    #1399   +/-   ##=======================================  Coverage   80.16%   80.16%           =======================================  Files          73       73             Lines        4073     4073           =======================================  Hits         3265     3265             Misses        808      808

Flag	Coverage Δ
unit	`80.16% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/v4/objects/merge_requests.py	`65.45% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update916a7fe...062f8f6. Read thecomment docs.

Copy link

Member

max-wittig commentedApr 19, 2021

That mistake happens too often in Python 😄

LGTM 👍

max-wittig merged commitfc4f7fd intopython-gitlab:master

Apr 19, 2021

Copy link

MemberAuthor

JohnVillalovos commentedApr 19, 2021

That mistake happens too often in Python 😄

One of the things I like with adding the static type-hints and then using mypy. That is how I caught this one. May find more issues as more and more type-hints are added.