NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

fix: correct some type-hints in gitlab/mixins.py#1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_mixins

Apr 20, 2021

Merged

fix: correct some type-hints in gitlab/mixins.py#1398

max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_mixins

Apr 20, 2021

Conversation

Copy link

Member

JohnVillalovos commentedApr 18, 2021

Commitbaea721 introduced type-hints
for gitlab/mixins.py.

After starting to add type-hints to gitlab/v4/objects/users.py
discovered a few errors.

Main error was using '=' instead of ':'. For example:
_parent = Optional[...] should be _parent: Optional[...]

Resolved those issues.

fix: correct some type-hints in gitlab/mixins.py

8bd3124

Commitbaea721 introduced type-hintsfor gitlab/mixins.py.After starting to add type-hints to gitlab/v4/objects/users.pydiscovered a few errors.Main error was using '=' instead of ':'. For example:  _parent = Optional[...] should be _parent: Optional[...]Resolved those issues.

Copy link

codecov-commenter commentedApr 18, 2021•
edited
Loading

Codecov Report

Merging#1398 (8bd3124) intomaster (916a7fe) willdecrease coverage by0.02%.
The diff coverage is92.30%.

@@            Coverage Diff             @@##           master    #1398      +/-   ##==========================================- Coverage   80.16%   80.13%   -0.03%==========================================  Files          73       73                Lines        4073     4077       +4     ==========================================+ Hits         3265     3267       +2- Misses        808      810       +2

Flag	Coverage Δ
unit	`80.13% <92.30%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/mixins.py	`77.22% <92.30%> (-0.26%)`	⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update916a7fe...8bd3124. Read thecomment docs.