- Notifications
You must be signed in to change notification settings - Fork673
feat: add feature to get inherited member for project/group#1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@JohnVillalovos this helps get rid of a custom method that prevented users from using the endpoint fully (only list was supported, not get, and even that didn't work properly like ListMixin). My only silly thought in the initial PR was that @Shkurupii thanks again and sorry for the delay, I will resolve the conflicts here so you don't have to rebase again. One caveat is I think this will not work in the CLI because of how subcommands are constructed from object names (this reuses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Forgot to push the "Submit review" button a week or so ago...
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
JohnVillalovos commentedMay 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Based on how the API is I lean towards FYI: I did a rebase of this a week or so ago. Might help you. https://github.com/JohnVillalovos/python-gitlab/tree/jlvillal/feat-get-inherited-members |
83f8d03
to4b716a3
Compare4b716a3
toe444b39
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Shkurupii thanks, I just rebased/squashed this and added a few more fixes that come from more recent typing and pep8 checks but I've kept you as author.
I'll let@JohnVillalovos merge though so I don't self-approve 😁
Oh sorry! I must have missed this 😢 Thanks for merging! |
Uh oh!
There was an error while loading.Please reload this page.
Hi!
First of all excuse me for inconvenience. I failed my previous PR(#1187) branch during rebasing, so PR automatically were closed.
Briefly, PR about the same, feature#1133, and taking into account@nejch 's suggestion from (#1187)
Here I propose to introduce new custom managers ProjectMemberAllManager (/projects/:id/members/all/:user_id) and GroupMemberAllManager (/groups/:id/members/all/:user_id). Subsequently, in order to fetch a list or instance of members including inherited ones, you will need to:
@JacobHenner , just fyi.
Closes#1133