- Notifications
You must be signed in to change notification settings - Fork673
chore: remove usage of getattr()#1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -2,9 +2,12 @@ | ||
| Gitlab API: https://docs.gitlab.com/ee/api/merge_request_approvals.html | ||
| """ | ||
| import copy | ||
| import pytest | ||
| import responses | ||
| import gitlab | ||
| approval_rule_id = 1 | ||
| @@ -230,6 +233,17 @@ def resp_snippet(): | ||
| yield rsps | ||
| def test_project_approval_manager_update_uses_post(project, resp_snippet): | ||
| """Ensure the | ||
| gitlab.v4.objects.merge_request_approvals.ProjectApprovalManager object has | ||
| _update_uses_post set to True""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I was originally thinking this would be more appropriate in a separate test/fake manager, to test just this specific aspect of it, e.g. in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I can do that, though I'm not quite sure what you want me to do 😕 Do you want a test that shows that | ||
| approvals = project.approvals | ||
| assert isinstance( | ||
| approvals, gitlab.v4.objects.merge_request_approvals.ProjectApprovalManager | ||
| ) | ||
| assert approvals._update_uses_post == True | ||
| def test_list_merge_request_approval_rules(project, resp_snippet): | ||
| approval_rules = project.mergerequests.get(1).approval_rules.list() | ||
| assert len(approval_rules) == 1 | ||
| @@ -239,6 +253,11 @@ def test_list_merge_request_approval_rules(project, resp_snippet): | ||
| def test_update_merge_request_approvals_set_approvers(project, resp_snippet): | ||
| approvals = project.mergerequests.get(1).approvals | ||
| assert isinstance( | ||
| approvals, | ||
| gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager, | ||
| ) | ||
| assert approvals._update_uses_post == True | ||
| response = approvals.set_approvers( | ||
| updated_approval_rule_approvals_required, | ||
| approver_ids=updated_approval_rule_user_ids, | ||
| @@ -254,6 +273,11 @@ def test_update_merge_request_approvals_set_approvers(project, resp_snippet): | ||
| def test_create_merge_request_approvals_set_approvers(project, resp_snippet): | ||
| approvals = project.mergerequests.get(1).approvals | ||
| assert isinstance( | ||
| approvals, | ||
| gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager, | ||
| ) | ||
| assert approvals._update_uses_post == True | ||
| response = approvals.set_approvers( | ||
| new_approval_rule_approvals_required, | ||
| approver_ids=new_approval_rule_user_ids, | ||