NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

fix: checking if RESTManager._from_parent_attrs is set#1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/from_parent_attrs

Mar 10, 2021

Merged

fix: checking if RESTManager._from_parent_attrs is set#1367

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/from_parent_attrs

Mar 10, 2021

Conversation

Copy link

Member

JohnVillalovos commentedMar 7, 2021

Prior to commit3727cbd
RESTManager._from_parent_attrs did not exist unless it was explicitly
set. But commit3727cbd set it to a
default value of {}.

So the checks using hasattr() were no longer valid.

Update the checks to check if RESTManager._from_parent_attrs has a
value.

fix: checking if RESTManager._from_parent_attrs is set

8224b40

Prior to commit3727cbdRESTManager._from_parent_attrs did not exist unless it was explicitlyset. But commit3727cbd set it to adefault value of {}.So the checks using hasattr() were no longer valid.Update the checks to check if RESTManager._from_parent_attrs has avalue.

Copy link

codecov-io commentedMar 7, 2021

Codecov Report

Merging#1367 (8224b40) intomaster (de73ea7) willdecrease coverage by0.00%.
The diff coverage is62.50%.

@@            Coverage Diff             @@##           master    #1367      +/-   ##==========================================- Coverage   79.94%   79.93%   -0.01%==========================================  Files          73       73                Lines        4008     4011       +3     ==========================================+ Hits         3204     3206       +2- Misses        804      805       +1

Flag	Coverage Δ
unit	`79.93% <62.50%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/v4/cli.py	`40.71% <57.14%> (+0.31%)`	⬆️
gitlab/base.py	`84.86% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatede73ea7...8224b40. Read thecomment docs.