Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: have _create_attrs & _update_attrs be a namedtuple#1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/create_attrs
Apr 17, 2021
Merged

chore: have _create_attrs & _update_attrs be a namedtuple#1366

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/create_attrs
Apr 17, 2021

Conversation

@JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedMar 7, 2021•
edited
Loading

Convert _create_attrs and _update_attrs to use a NamedTuple
(RequiredOptional) to help with code readability. Update all code to
use the NamedTuple.

@JohnVillalovosJohnVillalovos marked this pull request as draftMarch 7, 2021 19:34
@codecov-io
Copy link

codecov-io commentedMar 7, 2021•
edited
Loading

Codecov Report

Merging#1366 (a421966) intomaster (8603248) willincrease coverage by0.01%.
The diff coverage is100.00%.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1366      +/-   ##==========================================+ Coverage   79.92%   79.94%   +0.01%==========================================  Files          73       73                Lines        4010     4013       +3     ==========================================+ Hits         3205     3208       +3  Misses        805      805
FlagCoverage Δ
unit79.94% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/base.py85.35% <100.00%> (+0.28%)⬆️
gitlab/mixins.py77.41% <100.00%> (ø)
gitlab/v4/cli.py41.63% <100.00%> (ø)
gitlab/v4/objects/appearance.py100.00% <100.00%> (ø)
gitlab/v4/objects/applications.py100.00% <100.00%> (ø)
gitlab/v4/objects/award_emojis.py100.00% <100.00%> (ø)
gitlab/v4/objects/badges.py100.00% <100.00%> (ø)
gitlab/v4/objects/boards.py100.00% <100.00%> (ø)
gitlab/v4/objects/branches.py73.52% <100.00%> (ø)
gitlab/v4/objects/broadcast_messages.py100.00% <100.00%> (ø)
... and34 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update8603248...a421966. Read thecomment docs.

@JohnVillalovosJohnVillalovos changed the titleWIP: chore: add _create_attrs & _update_attrs to RESTManagerchore: add _create_attrs & _update_attrs to RESTManagerMar 7, 2021
@JohnVillalovosJohnVillalovos changed the titlechore: add _create_attrs & _update_attrs to RESTManagerRFC: chore: add _create_attrs & _update_attrs to RESTManagerMar 7, 2021
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewMarch 7, 2021 22:34
@JohnVillalovos
Copy link
MemberAuthor

Breaking this up into smaller pieces.

@JohnVillalovosJohnVillalovos changed the titleRFC: chore: add _create_attrs & _update_attrs to RESTManagerchore: have _create_attrs & _update_attrs be a namedtupleMar 14, 2021
@JohnVillalovos
Copy link
MemberAuthor

@nejch Updated this with your feedback.

Convert _create_attrs and _update_attrs to use a NamedTuple(RequiredOptional) to help with code readability. Update all code touse the NamedTuple.
@nejch
Copy link
Member

@nejch Updated this with your feedback.

Thanks a lot for the hard work here, looks a lot clearer than the old code! Sorry for the delay, again :)
I didn't want to block this PR any longer so I just force-pushed a tiny change to delete a leftover tt.sh script, I hope that's ok. I'll merge in a minute.

@nejchnejch merged commitd1697d4 intopython-gitlab:masterApr 17, 2021
@JohnVillalovos
Copy link
MemberAuthor

@nejch Updated this with your feedback.

Thanks a lot for the hard work here, looks a lot clearer than the old code! Sorry for the delay, again :)
I didn't want to block this PR any longer so I just force-pushed a tiny change to delete a leftover tt.sh script, I hope that's ok. I'll merge in a minute.

Oh! Whoops on my part leaving thett.sh in there 😟

Thanks for the merge!

@JohnVillalovosJohnVillalovos deleted the jlvillal/create_attrs branchApril 18, 2021 17:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchnejch left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohnVillalovos@codecov-io@nejch
[8]ページ先頭
©2009-2025 Movatter.jp