Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Feat: cover all audit events#1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
max-wittig merged 5 commits intomasterfromfeat/all-audit-events
Mar 24, 2021
Merged

Conversation

nejch
Copy link
Member

This adds group audit events, moves all audit events into one module and makes the class naming consistent.

Closes#1107,closes#948.

max-wittig reacted with thumbs up emoji
@nejchnejchforce-pushed thefeat/all-audit-events branch from6101513 to23e37c5CompareMarch 7, 2021 12:12
@codecov-io
Copy link

Codecov Report

Merging#1363 (23e37c5) intomaster (48fc907) willincrease coverage by0.08%.
The diff coverage is100.00%.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1363      +/-   ##==========================================+ Coverage   79.92%   80.01%   +0.08%==========================================  Files          73       73                Lines        4010     4028      +18     ==========================================+ Hits         3205     3223      +18  Misses        805      805
FlagCoverage Δ
unit80.01% <100.00%> (+0.08%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/events.py100.00% <ø> (ø)
gitlab/v4/objects/__init__.py100.00% <100.00%> (ø)
gitlab/v4/objects/audit_events.py100.00% <100.00%> (ø)
gitlab/v4/objects/groups.py76.40% <100.00%> (+0.26%)⬆️
gitlab/v4/objects/projects.py73.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update48fc907...23e37c5. Read thecomment docs.

@max-wittig
Copy link
Member

@nejch Sorry for ignoring that for soo long. Looks good!

@max-wittigmax-wittig merged commit02ce49e intomasterMar 24, 2021
@max-wittigmax-wittig deleted the feat/all-audit-events branchMarch 24, 2021 10:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@max-wittigmax-wittig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for group audit events Add support for audit events
3 participants
@nejch@codecov-io@max-wittig
[8]ページ先頭
©2009-2025 Movatter.jp