***@***.**** requested changes on this pull request. Thanks a lot for this@klorenz <https://github.com/klorenz> I think some people have asked for this already and will be happy to see it fixed! I'll try to find related issues so we can close them if it fixes them. When I look at "Files changed" only one file is changed. Was that the intent? The second commit is a Merge commit which doesn't seem correct. It seems like this patch was started before gitlab/v4/objects/*init*.py was split up into multiple files. I agree with@JohnVillalovos <https://github.com/JohnVillalovos>, looks like with your merge you lost the custom _types attributes. Could you re-add them in the split objects/ files? Also looks like you had an unrelated change in the initial commit, please submit that as a separate PR if you add it back ;) Apart from John's comment see also my note on only overriding the right method. And finally since I see from the other PR that you're comfortable with unit tests here could you add one to prove it fixes the issue? ;) ------------------------------ In gitlab/types.py <#1360 (comment)> : > +class ScopesListAttribute(ListAttribute): + def set_from_cli(self, cli_value): + if not cli_value.strip(): + self._value = [] + else: + self._value = [item.strip() for item in cli_value.split(",")] + + def get_for_api(self): + # Do not comma-split single value passed as string + if isinstance(self._value, str): + return [self._value] + + return self._value + + Since you are inheriting from ListAttribute you don't need to duplicate methods. Just override the one you need to and maybe instead of copying the previous comment, add one (or a docstring) about why it needs to be different from the inherited class. Unless I missed a small difference in set_from_cli then please correct me 😁 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1360 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE2WZAXOJ5D6YDNTFHHZDTTCJSVVANCNFSM4YWTNIWQ> .