***@***.**** commented on this pull request. ------------------------------ In gitlab/config.py <#1359 (comment)> : > @@ -150,6 +151,16 @@ def __init__( except Exception: pass + for attr in ("job_token", "http_password", "private_token", "oauth_token"): + value = getattr(self, attr) + prefix = "lookup:" + if isinstance(value, str) and value.lower().strip().startswith(prefix): + helper = value[len(prefix) :].strip() + value = ( + subprocess.check_output(helper, shell=True).decode("utf-8").strip() Thank you for the changes@klorenz <https://github.com/klorenz> and sorry for the delay! I'll be merging in a minute. I really liked the convenience of your initial implementation, and I don't want to block this PR any longer so I just pushed a small change (I credited you as the author still) - I went for a compromise where shell=False is still used and recommend wrappers for any scripts that require piping etc. I hope this is ok with you. I also expanded the docs and wrapped the call in a try/except block for people to have a meaningful erorr message on the CLI. See91ffb8e <91ffb8e>, let me know if you want to revisit this in a follow-up. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1359 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE2WZADPHXO37LIOFOMXWLTJKV6JANCNFSM4YWO4IXA> .