NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

chore: add type hints to gitlab/base.py:RESTManager#1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_base

Mar 6, 2021

Merged

chore: add type hints to gitlab/base.py:RESTManager#1353

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_base

Mar 6, 2021

Conversation

Copy link

Member

JohnVillalovos commentedMar 2, 2021

Add some additional type hints to gitlab/base.py

chore: add type hints to gitlab/base.py:RESTManager

9c55593

Add some additional type hints to gitlab/base.py

Copy link

codecov-io commentedMar 2, 2021

Codecov Report

Merging#1353 (9c55593) intomaster (96d2805) willincrease coverage by0.02%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master    #1353      +/-   ##==========================================+ Coverage   80.21%   80.23%   +0.02%==========================================  Files          73       73                Lines        3801     3805       +4     ==========================================+ Hits         3049     3053       +4  Misses        752      752

Flag	Coverage Δ
unit	`80.23% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/base.py	`84.66% <100.00%> (+0.42%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update96d2805...9c55593. Read thecomment docs.