NotificationsYou must be signed in to change notification settings
Fork676
Star2.4k

chore: add additional type-hints for gitlab/base.py#1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_base_fixes

Feb 28, 2021

Merged

chore: add additional type-hints for gitlab/base.py#1345

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_base_fixes

Feb 28, 2021

Conversation

Copy link

Member

JohnVillalovos commentedFeb 27, 2021•
edited
Loading

Add type-hints for the variables which are set via self.dict

mypy doesn't see them when they are assigned via self.dict. So
declare them in the class definition.

Copy link

codecov-io commentedFeb 27, 2021•
edited
Loading

Codecov Report

Merging#1345 (ad72ef3) intomaster (b0d75d9) willincrease coverage by0.03%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master    #1345      +/-   ##==========================================+ Coverage   80.07%   80.10%   +0.03%==========================================  Files          72       72                Lines        3764     3770       +6     ==========================================+ Hits         3014     3020       +6  Misses        750      750

Flag	Coverage Δ
unit	`80.10% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/base.py	`84.50% <100.00%> (+0.68%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb0d75d9...ad72ef3. Read thecomment docs.

chore: add additional type-hints for gitlab/base.py

ad72ef3

Add type-hints for the variables which are set via self.__dict__mypy doesn't see them when they are assigned via self.__dict__. Sodeclare them in the class definition.