NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

chore: disallow incomplete type defs#1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_incomplete

Feb 28, 2021

Merged

chore: disallow incomplete type defs#1342

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_incomplete

Feb 28, 2021

Conversation

Copy link

Member

JohnVillalovos commentedFeb 27, 2021

Don't allow a partially annotated function definition. Either none of
the function is annotated or all of it must be.

Update code to ensure no-more partially annotated functions.

Update gitlab/cli.py with better type-hints. Changed Tuple[Any, ...]
to Tuple[str, ...]

JohnVillalovos marked this pull request as draft

February 27, 2021 01:42

Copy link

codecov-io commentedFeb 27, 2021

Codecov Report

Merging#1342 (a913d6f) intomaster (b0d75d9) willdecrease coverage by0.02%.
The diff coverage is92.59%.

@@            Coverage Diff             @@##           master    #1342      +/-   ##==========================================- Coverage   80.07%   80.04%   -0.03%==========================================  Files          72       72                Lines        3764     3769       +5     ==========================================+ Hits         3014     3017       +3- Misses        750      752       +2

Flag	Coverage Δ
unit	`80.04% <92.59%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/utils.py	`71.42% <50.00%> (-2.11%)`	⬇️
gitlab/base.py	`83.57% <87.50%> (-0.26%)`	⬇️
gitlab/cli.py	`53.57% <100.00%> (ø)`
gitlab/client.py	`80.67% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb0d75d9...a913d6f. Read thecomment docs.

chore: disallow incomplete type defs

907634f

Don't allow a partially annotated function definition. Either none ofthe function is annotated or all of it must be.Update code to ensure no-more partially annotated functions.Update gitlab/cli.py with better type-hints. Changed Tuple[Any, ...]to Tuple[str, ...]

JohnVillalovos marked this pull request as ready for review

February 28, 2021 17:14