- Notifications
You must be signed in to change notification settings - Fork673
chore: remove import of gitlab.utils from __init__.py#1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/gitlab_initFeb 26, 2021
Merged
chore: remove import of gitlab.utils from __init__.py#1340
max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/gitlab_initFeb 26, 2021
+0 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Initially when extracting out the gitlab/client.py code we tried toremove this but functional tests failed.Later we fixed the functional test that was failing, so now remove theunneeded import.
codecov-io commentedFeb 26, 2021
Codecov Report
@@ Coverage Diff @@## master #1340 +/- ##==========================================- Coverage 80.28% 80.28% -0.01%========================================== Files 72 72 Lines 3744 3743 -1 ==========================================- Hits 3006 3005 -1 Misses 738 738
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially when extracting out the gitlab/client.py code we tried to
remove this but functional tests failed.
Later we fixed the functional test that was failing, so now remove the
unneeded import.