Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add type-hints to gitlab/client.py#1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_client_py
Feb 27, 2021
Merged

chore: add type-hints to gitlab/client.py#1339

max-wittig merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_client_py
Feb 27, 2021

Conversation

JohnVillalovos
Copy link
Member

Adding some initial type-hints to gitlab/client.py

Unsure about my usage of assert to identify the type of the object. Feedback appreciated.

@JohnVillalovosJohnVillalovos marked this pull request as draftFebruary 26, 2021 19:53
Adding some initial type-hints to gitlab/client.py
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewFebruary 26, 2021 20:57
@max-wittig
Copy link
Member

@JohnVillalovos I love these type merge requests. Just a quick question. What about the depreciation of the typing module in Python 3.9? We may need some feature imports then right?

@JohnVillalovos
Copy link
MemberAuthor

@JohnVillalovos I love these type merge requests. Just a quick question. What about the depreciation of the typing module in Python 3.9? We may need some feature imports then right?

I was not aware of that. But I just read this:https://docs.python.org/3/library/typing.html

The deprecated types will be removed from the typing module in the first Python version released 5 years after the release of Python 3.9.0.

Which sounds like we will have 5 years to take care of this. Maybe I misunderstand that.

@max-wittig
Copy link
Member

Okay then it should be fine.

@max-wittigmax-wittig merged commitb0d75d9 intopython-gitlab:masterFeb 27, 2021
@max-wittig
Copy link
Member

Thanks for the MR!

JohnVillalovos reacted with thumbs up emoji

@JohnVillalovos
Copy link
MemberAuthor

Thanks for the MR!

Slowly coming along. One file at a time!

@JohnVillalovosJohnVillalovos deleted the jlvillal/mypy_client_py branchMarch 14, 2021 17:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@max-wittigmax-wittigmax-wittig left review comments

Assignees

@JohnVillalovosJohnVillalovos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JohnVillalovos@max-wittig
[8]ページ先頭
©2009-2025 Movatter.jp