Mar 6, 2021 · Feb 25, 2021
diff --git a/gitlab/tests/test_utils.py b/gitlab/tests/test_utils.py
    dest = "foo%23bar%2Fbaz%2F"
    assert dest == utils.clean_str_id(src)

    src = "foo%bar/baz/"
    dest = "foo%25bar%2Fbaz%2F"
    assert dest == utils.clean_str_id(src)


 def test_sanitized_url():
    src = "http://localhost/foo/bar"
    assert "foo%2Fbar" == utils.sanitize_parameters("foo/bar")


 def test_sanitize_parameters_slash_and_percent():
    assert "foo%2Fbar%25quuz" == utils.sanitize_parameters("foo/bar%quuz")


 def test_sanitize_parameters_dict():
    source = {"url": "foo/bar", "id": 1}
    expected = {"url": "foo%2Fbar", "id": 1}
diff --git a/gitlab/utils.py b/gitlab/utils.py
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.

 fromtypingimportAny,Callable,Dict,Optional
 fromurllib.parseimporturlparse
 fromurllib.parseimportquote,urlparse

 importrequests



 defclean_str_id(id:str)->str:
 returnid.replace("/","%2F").replace("#","%23")
 returnquote(id,safe="")


 defsanitize_parameters(value):
 ifisinstance(value,dict):
 returndict((k,sanitize_parameters(v))fork,vinvalue.items())
 ifisinstance(value,str):
 returnvalue.replace("/","%2F")
 returnquote(value,safe="")
 returnvalue
Original file line number	Diff line number	Diff line change
Expand Up		@@ -27,6 +27,10 @@ def test_clean_str_id():
		dest = "foo%23bar%2Fbaz%2F"
		assert dest == utils.clean_str_id(src)

		src = "foo%bar/baz/"
		dest = "foo%25bar%2Fbaz%2F"
		assert dest == utils.clean_str_id(src)


		def test_sanitized_url():
		src = "http://localhost/foo/bar"
Expand All		@@ -48,6 +52,10 @@ def test_sanitize_parameters_slash():
		assert "foo%2Fbar" == utils.sanitize_parameters("foo/bar")


		def test_sanitize_parameters_slash_and_percent():
		assert "foo%2Fbar%25quuz" == utils.sanitize_parameters("foo/bar%quuz")


		def test_sanitize_parameters_dict():
		source = {"url": "foo/bar", "id": 1}
		expected = {"url": "foo%2Fbar", "id": 1}
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -16,7 +16,7 @@
		# along with this program. If not, see <http://www.gnu.org/licenses/>.

		fromtypingimportAny,Callable,Dict,Optional
		fromurllib.parseimporturlparse
		fromurllib.parseimportquote,urlparse

		importrequests

Expand DownExpand Up		@@ -57,14 +57,14 @@ def copy_dict(dest: Dict[str, Any], src: Dict[str, Any]) -> None:


		defclean_str_id(id:str)->str:
		returnid.replace("/","%2F").replace("#","%23")
		returnquote(id,safe="")


		defsanitize_parameters(value):
		ifisinstance(value,dict):
		returndict((k,sanitize_parameters(v))fork,vinvalue.items())
		ifisinstance(value,str):
		returnvalue.replace("/","%2F")
		returnquote(value,safe="")
		returnvalue


Expand Down