todo: technically this breaks the CLIgitlab project-merge-request pipelines and requiresproject-merge-request-pipelines list instead. I'll see if I can hack theregister_custom_action decorator to accept custom action names, not just the current method name. I had to remove it as there would be a namespace clash between the old method and the new manager.

Well, I've managed to hackregister_custom_action a little so it takes an optionalcustom_action argument to override the current function name as the CLI action, so should be backwards compatible, but then realized the old method probably never worked in CLI due to missing CLI args 🤦

Still, now you can do (until 3.0.0 or so, but probably useless anyway):

gitlab project-merge-request pipelines --helpusage: gitlab project-merge-request pipelines [-h] --project-id PROJECT_ID [--sudo SUDO] --iid IIDoptional arguments:  -h, --help            show thishelp message andexit  --project-id PROJECT_ID  --sudo SUDO  --iid IID

And the new list, with proper help and args:

gitlab project-merge-request-pipeline list --helpusage: gitlab merge-request-pipeline list [-h] [--sudo SUDO] --project-id PROJECT_ID --mr-iid MR_IID                                          [--page PAGE] [--per-page PER_PAGE] [--all]optional arguments:  -h, --help            show thishelp message andexit  --sudo SUDO  --project-id PROJECT_ID  --mr-iid MR_IID  --page PAGE  --per-page PER_PAGE  --all

nejch mentioned this pull request

Feb 23, 2021

ProjectMergeRequest.pipelines() returns a 'list' instead of documented 'RESTObjectList'#1312

Closed

nejch force-pushed thefeat/mr-pipeline-manager branch 3 times, most recently fromc8fed5a tof12841fCompare

February 26, 2021 19:35

nejch marked this pull request as ready for review

February 26, 2021 19:49

nejch assignedmax-wittig

Feb 26, 2021

Copy link

MemberAuthor

nejch commentedFeb 26, 2021

Maybe@JohnVillalovos you want to have a look at the typing here as well, I always forget decorators and have to google the wrap functions every time I work with them 🤣

Copy link

Member

JohnVillalovos commentedFeb 26, 2021

Maybe@JohnVillalovos you want to have a look at the typing here as well, I always forget decorators and have to google the wrap functions every time I work with them 🤣

From my initial look it seems correct. Also mypy is checking thatgitlab/cli.py file, so seems good.

Looks Good To Me (LGTM) 👍

Thanks!

Copy link

Member

max-wittig commentedFeb 26, 2021

We're most likely gonna go to 3.0.0 directly, because of this breaking change:#1278. Maybe have those two in one release would be nice 😄

Copy link

msune commentedMar 29, 2021

👍 on this.

I seem to be hitting a limitation/bug ofpipelines()#1312 (comment) and in another issue that I will not bother mentioning.

Any chance this could be integrated soon?

nejch added this to thev3.0.0 milestone

Apr 27, 2021

Copy link

Member

max-wittig commentedMay 31, 2021

@nejch Sorry for making you wait for long that everything conflicts. I just see like 15 notifications everyday from this project. You people are crazy 😄

Would you mind to rebase?