NotificationsYou must be signed in to change notification settings
Fork674
Star2.4k

fix: undefined name errors#1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/missing_vars

Feb 23, 2021

Merged

fix: undefined name errors#1322

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/missing_vars

Feb 23, 2021

Conversation

Copy link

Member

JohnVillalovos commentedFeb 23, 2021

Discovered that there were some undefined names.

fix: undefined name errors

48ec9e0

Discovered that there were some undefined names.

Copy link

codecov-io commentedFeb 23, 2021

Codecov Report

Merging#1322 (48ec9e0) intomaster (d90be1e) willnot change coverage.
The diff coverage is25.00%.

@@           Coverage Diff           @@##           master    #1322   +/-   ##=======================================  Coverage   80.25%   80.25%           =======================================  Files          71       71             Lines        3738     3738           =======================================  Hits         3000     3000             Misses        738      738

Flag	Coverage Δ
unit	`80.25% <25.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/v4/objects/ldap.py	`54.54% <0.00%> (ø)`
gitlab/v4/objects/projects.py	`69.20% <33.33%> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updated90be1e...48ec9e0. Read thecomment docs.

nejch approved these changes

Feb 23, 2021

View reviewed changes

Copy link

Member

nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wow thanks, really need more test coverage for this.

Some of this must have just worked before some of the refactoring because of those blanket imports. Or no one ever noticed 🤔

nejch merged commita7ec67f intopython-gitlab:master

Feb 23, 2021

Copy link

MemberAuthor

JohnVillalovos commentedFeb 24, 2021

Wow thanks, really need more test coverage for this.
Some of this must have just worked before some of the refactoring because of those blanket imports. Or no one ever noticed 🤔

I ran flake8 locally after doing the patch to remove the 'import *' lines. And found these missing names.