Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: remove usage of 'from ... import *' in client.py#1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/testing
Feb 22, 2021
Merged

chore: remove usage of 'from ... import *' in client.py#1318

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/testing
Feb 22, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedFeb 22, 2021•
edited
Loading

In gitlab/client.py remove usage of:  * from gitlab.const import *  * from gitlab.exceptions import *Change them to:  * import gitlab.const  * import gitlab.exceptionsUpdate code to explicitly reference things in gitlab.const andgitlab.exceptionsA flake8 run no longer lists any undefined variables. Before it listedpossible undefined variables.

@JohnVillalovosJohnVillalovos marked this pull request as draftFebruary 22, 2021 21:49
@codecov-io
Copy link

codecov-io commentedFeb 22, 2021•
edited
Loading

Codecov Report

Merging#1318 (5165354) intomaster (3aef19c) willdecrease coverage by0.03%.
The diff coverage is75.00%.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1318      +/-   ##==========================================- Coverage   80.76%   80.72%   -0.04%==========================================  Files          69       69                Lines        3623     3627       +4     ==========================================+ Hits         2926     2928       +2- Misses        697      699       +2
FlagCoverage Δ
unit80.72% <75.00%> (-0.04%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/client.py80.00% <75.00%> (-0.35%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update3aef19c...5165354. Read thecomment docs.

In gitlab/client.py remove usage of:  * from gitlab.const import *  * from gitlab.exceptions import *Change them to:  * import gitlab.const  * import gitlab.exceptionsUpdate code to explicitly reference things in gitlab.const andgitlab.exceptionsA flake8 run no longer lists any undefined variables. Before it listedpossible undefined variables.
@JohnVillalovosJohnVillalovos changed the titleTesting...chore: remove usage of 'from ... import *' in client.pyFeb 22, 2021
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewFebruary 22, 2021 22:17
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Would make sense to get rid of these blanket imports even in init but there are many things advertised publicly from that namespace even in docs (https://python-gitlab.readthedocs.io/en/stable/search.html?q=constants).

@nejchnejch merged commitd9fdf1d intopython-gitlab:masterFeb 22, 2021
@JohnVillalovosJohnVillalovos deleted the jlvillal/testing branchFebruary 24, 2021 01:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@codecov-io@nejch
[8]ページ先頭
©2009-2025 Movatter.jp