- Notifications
You must be signed in to change notification settings - Fork673
feat: add project audit endpoint#1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot for this@Sineaggi! Just one small comment.
BTW - It might make sense to separate this into its own module,audit_events.py
. Looking at the upstream docs, we also have instance and group audit events, so this could be expanded at a later point, and look something like the variables module:
https://github.com/python-gitlab/python-gitlab/blob/master/gitlab/v4/objects/variables.py
EDIT: I realize now that the current instance-level audit events were put intoevents.py
, but they seem to have their own section in gitlab's api, so moving them together intoaudit_events.py
might still make sense.
Then import the project-specific classes inprojects.py
.
If you feel like it, you could also add some unit tests for this as a sanity check, using the example responses from your API link as mocks. Have a look at the existing unit tests:https://github.com/python-gitlab/python-gitlab/tree/master/gitlab/tests/objects
Thanks again!
Uh oh!
There was an error while loading.Please reload this page.
1f5c5bf
todba3483
Comparecodecov-io commentedFeb 19, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1308 +/- ##==========================================+ Coverage 80.64% 80.71% +0.06%========================================== Files 66 67 +1 Lines 3250 3261 +11 ==========================================+ Hits 2621 2632 +11 Misses 629 629
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
@nejch code moved to |
dba3483
to868cea9
Compare868cea9
to6660dbe
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks again! Just found a little copy/paste leftover, I can push this.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Similar to#949 but specific toproject audit events.
No previous issues for this exist.
The code was tested to verify it works.