NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

chore: remove unused ALLOWED_KEYSET_ENDPOINTS variable#1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:remove_cruft

Feb 16, 2021

Merged

chore: remove unused ALLOWED_KEYSET_ENDPOINTS variable#1300

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:remove_cruft

Feb 16, 2021

Conversation

Copy link

Member

JohnVillalovos commentedFeb 15, 2021

The variable ALLOWED_KEYSET_ENDPOINTS was added in commit
f86ef3b.

Then most of that commit was removed in commit
e71fe16, but ALLOWED_KEYSET_ENDPOINTS
was missed.

chore: remove unused ALLOWED_KEYSET_ENDPOINTS variable

3d5d5d8

The variable ALLOWED_KEYSET_ENDPOINTS was added in commitf86ef3b.Then most of that commit was removed in commite71fe16, but ALLOWED_KEYSET_ENDPOINTSwas missed.

Copy link

Member

nejch commentedFeb 16, 2021

I think this can go for now but for context, it was meant to follow endpoints where GitLab supports keyset pagination but it seems they're so far still stuck with only /projects (https://docs.gitlab.com/ee/api/README.html#keyset-based-pagination) and it broke some people's workflows initially due to missing headers.

@max-wittig maybe we can re-add this e.g.togitlab.const whenhttps://github.com/python-gitlab/python-gitlab/issues?q=is%3Aissue+is%3Aopen+keyset are revisited 😄