Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Enable mypy type checking and add type hints to gitlab/base.py#1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 2 commits intopython-gitlab:masterfromJohnVillalovos:mypy
Feb 23, 2021
Merged

Enable mypy type checking and add type hints to gitlab/base.py#1299

nejch merged 2 commits intopython-gitlab:masterfromJohnVillalovos:mypy
Feb 23, 2021

Conversation

@JohnVillalovos
Copy link
Member

Add an initial mypy test to test gitlab/base.py and gitlab/init.py

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks again@JohnVillalovos. Maybe this could be added to CI as well then, e.g. with the lint jobs:

Although the test workflows might give you an idea on how to add tox.

@codecov-io
Copy link

codecov-io commentedFeb 20, 2021•
edited
Loading

Codecov Report

Merging#1299 (abc715b) intomaster (2b29776) willincrease coverage by0.02%.
The diff coverage is100.00%.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1299      +/-   ##==========================================+ Coverage   80.76%   80.78%   +0.02%==========================================  Files          69       69                Lines        3623     3628       +5     ==========================================+ Hits         2926     2931       +5  Misses        697      697
FlagCoverage Δ
unit80.78% <100.00%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/base.py83.82% <100.00%> (+0.61%)⬆️
gitlab/client.py80.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update2b29776...abc715b. Read thecomment docs.

@JohnVillalovosJohnVillalovos changed the titleRFC: feat: add an initial mypy test to tox.iniWIP: feat: add an initial mypy test to tox.iniFeb 20, 2021
@JohnVillalovosJohnVillalovos changed the titleWIP: feat: add an initial mypy test to tox.iniEnable mypy type checking and add type hints to gitlab/base.pyFeb 21, 2021
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a left a few more comments on the CI/tox setup, not sure if this is still WIP or if the file list is complete :)

@JohnVillalovosJohnVillalovos marked this pull request as draftFebruary 21, 2021 16:35
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewFebruary 21, 2021 17:30
@JohnVillalovos
Copy link
MemberAuthor

I think I have done all the requested changes and I believe it is ready for review now. Thanks.

Add an initial mypy test to test gitlab/base.py and gitlab/__init__.py
@JohnVillalovos
Copy link
MemberAuthor

Rebased to fix merge conflicts

@nejchnejch merged commita18bc5c intopython-gitlab:masterFeb 23, 2021
@JohnVillalovos
Copy link
MemberAuthor

Woo hoo, merged! 🙂

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchnejch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohnVillalovos@codecov-io@nejch
[8]ページ先頭
©2009-2025 Movatter.jp