NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

feat: import from bitbucket server#1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromfajpunk:import_bitbucket

Feb 5, 2021

Merged

feat: import from bitbucket server#1283

nejch merged 1 commit intopython-gitlab:masterfromfajpunk:import_bitbucket

Feb 5, 2021

+129 −3

Conversation

Copy link

fajpunk commentedFeb 4, 2021

I'd like to use this libary to automate importing Bitbucket Server
repositories into GitLab. There is aGitLab API
endpoint
to do this, but it is not exposed through this library.

Add animport_bitbucket_server method to theProjectManager. This
method calls this GitLab API endpoint:
https://docs.gitlab.com/ee/api/import.html#import-repository-from-bitbucket-server
Add a basic unit test for the existingimport_github method

Copy link

Author

fajpunk commentedFeb 4, 2021

I cribbed this directly from the existingimport_github method

nejch requested changes

Feb 4, 2021

View reviewed changes

Copy link

Member

nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great@fajpunk thanks! Just a few notes.

I was going to suggest adding some docs (like inhttps://github.com/python-gitlab/python-gitlab/blob/77ac8c300fc647f18d4a71b84ae18a751bc1716f/docs/gl_objects/projects.rst#import--export) but the docstring, like for github is already pretty descriptive.

gitlab/tests/objects/test_projects.pyShow resolvedHide resolved

gitlab/v4/objects/__init__.py OutdatedShow resolvedHide resolved

gitlab/tests/objects/test_projects.pyShow resolvedHide resolved

fajpunk force-pushed theimport_bitbucket branch fromb67692f to7a858bbCompare

February 4, 2021 23:39

feat: import from bitbucket server

ff3013a

I'd like to use this libary to automate importing Bitbucket Serverrepositories into GitLab.  There is a [GitLab APIendpoint](https://docs.gitlab.com/ee/api/import.html#import-repository-from-bitbucket-server)to do this, but it is not exposed through this library.* Add an `import_bitbucket_server` method to the `ProjectManager`.  This  method calls this GitLab API endpoint:https://docs.gitlab.com/ee/api/import.html#import-repository-from-bitbucket-server* Modify `import_gitlab` method docstring for python3 compatibility* Add a skipped stub test for the existing `import_github` method