Thanks for this@gokeefe! Just added a small comment. Do you have a link for the upstream issue with the missing response?

Yes, right here:https://gitlab.com/gitlab-org/gitlab/-/issues/297559

I rebased your branch on top of master as we switched CI systems recently and this should give you better build results.

Awesome, the travis-ci build failed and I had no idea why because the same tests were working fine locally. I'll have a look at the rest next week. Thanks!

Thanks for this@gokeefe! Just added a small comment. Do you have a link for the upstream issue with the missing response?

Yes, right here:https://gitlab.com/gitlab-org/gitlab/-/issues/297559

I rebased your branch on top of master as we switched CI systems recently and this should give you better build results.

Awesome, the travis-ci build failed and I had no idea why because the same tests were working fine locally. I'll have a look at the rest next week. Thanks!

Just FYI - we've split the objects package into modules now so this will have to be rebased and moved intogitlab/v4/objects/push_rules.py and the manager also imported ingroups.py. Take a look at#1304 for an example on how to add it.

I'll assign this to you for now but if you need help just let me know :)

Hi@gokeefe are you still interested in finishing this?

I think we're ok without pytest and I can add them later if you're not comfortable doing that. This just needs a rebase to resolve some conflicts and maybe squash into a single commit. Let me know!

@nejch I rebased this PR, then squashed it down to one commit and cleaned things up a little bit. If you have time to review I can work on it some more if needed.