- Notifications
You must be signed in to change notification settings - Fork673
fix(api): add missing GetMixin to ProjectLabelManager#1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nejch requested changesJan 10, 2021
Uh oh!
There was an error while loading.Please reload this page.
Allows to get a single label from a project, which was missing beforeeven though the GitLab API has the ability to.
1bed2e8 tob6c55e2Compareb6c55e2 toa41af90Comparecodecov-io commentedJan 10, 2021
Codecov Report
@@ Coverage Diff @@## master #1263 +/- ##======================================= Coverage 78.04% 78.04% ======================================= Files 11 11 Lines 2865 2865 ======================================= Hits 2236 2236 Misses 629 629
Continue to review full report at Codecov.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ProjectLabelManager was missing the GetMixin, which made it impossible to get labels by name or ID, even though this is supported by the GitLab API.