Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(users): force 10 seconds sleep to improve reliability#1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
max-wittig wants to merge1 commit intomasterfromfix/flaky-test
Closed
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletiontools/functional/api/test_users.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ def test_delete_user(gl, wait_for_sidekiq):
"password":"delete-user-pass",
}
)

time.sleep(10)
new_user.delete()
Comment on lines +57 to 58
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this should go after, because the delete itself is taking too long:

Suggested change
time.sleep(10)
new_user.delete()
new_user.delete()
time.sleep(10)

Looks like we really need this. I thought my little sidekiq wait hack would work though 🤕 I based it off ofthis, but I'm not sure if we can extract from the API whenthis exact sidekiq deletion job is finished:

We can't guarantee when the user will actually be deleted by Sidekiq; this could take a while if the user has a lot of projects/events/etc.

I'll keep looking into this later, maybe we could also just wrap these asserts in retries until the condition is met (with a timeout), since it seems to me like GitLab gets more bloated with new features and so things can take longer with new releases on these little Travis VMs?

They do perform better during the day/office hours though, just retried all the jobs and they're going green 🤣

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe use something likeflaky for this?

wait_for_sidekiq()

Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp