NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

refactor(tests): split functional tests#1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

max-wittig merged 2 commits intomasterfromrefactor/split-functional-tests

Oct 9, 2020

Merged

refactor(tests): split functional tests#1205

max-wittig merged 2 commits intomasterfromrefactor/split-functional-tests

Oct 9, 2020

Conversation

Copy link

Member

nejch commentedOct 8, 2020•
edited
Loading

Glorious copy/paste time! This just splits functional tests in the hope we get more control over weird timing failures.
No attempts yet to add fixture factories which would be very useful here :P But for now, this provides await_for_sidekiq helper that should hopefully make it easier to solve if there are still issues.

This will be a pain to review, I wish GitHub/GitLab had code move detection like Review Board :( But the file sizes should be more reasonable now:

$ ls tools/functional/api/*.py | xargs wc -l | sort -h   12 tools/functional/api/test_deploy_keys.py   13 tools/functional/api/test_packages.py   36 tools/functional/api/test_deploy_tokens.py   42 tools/functional/api/test_current_user.py   46 tools/functional/api/test_clusters.py   48 tools/functional/api/test_variables.py   61 tools/functional/api/test_import_export.py   74 tools/functional/api/test_snippets.py   89 tools/functional/api/test_issues.py   96 tools/functional/api/test_merge_requests.py  126 tools/functional/api/test_repository.py  170 tools/functional/api/test_users.py  183 tools/functional/api/test_gitlab.py  190 tools/functional/api/test_groups.py  298 tools/functional/api/test_projects.py

Closes#1113,#1105,#1065, hopefullycloses#1033.

Also I realized when doing this that anything to do with group creation/deletion isreally slow so maybe it'll help with#1194.

nejch commented

Oct 8, 2020

View reviewed changes

tools/functional/conftest.py OutdatedShow resolvedHide resolved

nejch marked this pull request as ready for review

October 8, 2020 00:26

Copy link

codecov-io commentedOct 8, 2020•
edited
Loading

Codecov Report

Merging#1205 intomaster willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #1205   +/-   ##=======================================  Coverage   77.56%   77.56%           =======================================  Files          11       11             Lines        2826     2826           =======================================  Hits         2192     2192             Misses        634      634

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update2002098...65ce026. Read thecomment docs.