- Notifications
You must be signed in to change notification settings - Fork675
Feature/project merge request approval rules#1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Feature/project merge request approval rules#1200
Uh oh!
There was an error while loading.Please reload this page.
Conversation
84b4735 toc6fbf39Comparemax-wittig commentedOct 12, 2020
Hi@robinson96 thanks for the MR! Would you mind to add some docs and tests to this? I can't really test EE features, but I will take a look based on your docs! |
robinson96 commentedOct 13, 2020
I will certainly add docs. I too lack a great way to do EE testing, I developGRAPE, which has some features for maintaining pull requests. It works in that context. (branch unfortunately is on a repo hosting service that is not public). |
robinson96 commentedOct 14, 2020
@max-wittig , I'm trying to findtest_merge_requests.py so I can modify it to add appropriate tests, but am coming up short. (My python testing skills are still developing). Any hints on where to be looking? (tools/functional/api/ only has a few of the files that Travis appears to be exercising...) |
max-wittig commentedOct 14, 2020
Our unittests are here:https://github.com/python-gitlab/python-gitlab/tree/master/gitlab/tests/objects And functional tests are here:https://github.com/python-gitlab/python-gitlab/tree/master/tools/functional/api For this, it's only possible to add unit tests, as we run the functional tests against GitLab Core |
robinson96 commentedOct 15, 2020
Thanks. Tests are added! |
robinson96 commentedOct 19, 2020
@max-wittig - any other concerns with this PR? |
max-wittig left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah yes sorry I forgot to press the submit review button
docs/gl_objects/mr_approvals.rst Outdated
| approver_group_ids=[653, 654]) | ||
| approver_group_ids=[653, 654]) | ||
| Create a new MR-level approval rule or Change existing MR-level approval rule:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Create a new MR-level approval rule orChange existing MR-level approval rule:: | |
| Create a new MR-level approval rule orchange an existing MR-level approval rule:: |
Uh oh!
There was an error while loading.Please reload this page.
robinson96 commentedOct 22, 2020
@max-wittig - any other concerns? |
robinson96 commentedOct 28, 2020
@max-wittig - any other concerns with this branch? |
max-wittig commentedOct 29, 2020
thanks for the PR and sorry for the time it took to merge |
robinson96 commentedOct 29, 2020
@max-wittig - no worries and thanks for walking me through it! |
Addresses#1199.