- Notifications
You must be signed in to change notification settings - Fork673
Add support to resource milestone events#1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Bad commit message |
@max-wittig take a look, please! |
Thanks for the MR. Could you just please add some tests to it? 👍 |
What kind of tests? Please, elaborate. I am using "resourcelabelevents" for a starting point, so I have added to python_test_v4.py another two tests for milestones as same as for the resourcelabelevents. |
You've added functional tests. Would you mind to also add some unittests here?https://github.com/python-gitlab/python-gitlab/tree/master/gitlab/tests/objects |
@max-wittig Hi, check this out. Also, I can't understand why black fails my changes. WDYT? Please, advise. |
Found out that Travis black is a higher version than mine. Add another commit to make linter happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm sorry for the black breakage. I guess it makes sense to pin the version.
Thanks for the MR!
Closes#1154