NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

Enable updates on ProjectIssueNotes#113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gpocentek merged 3 commits intopython-gitlab:masterfromadamreid:master

May 12, 2016

Merged

Enable updates on ProjectIssueNotes#113

gpocentek merged 3 commits intopython-gitlab:masterfromadamreid:master

May 12, 2016

Conversation

Copy link

adamreid commentedMay 6, 2016

According to theGitLab API Docs Issue comments can be updated by api calls. This very minor change enables this in python-gitlab

This is useful to me and perhaps others for things like annotating comments with references to external issue trackers not supported in GitLab already. This change would allow notes on issues to be modified and saved, for example:

importosfromgitlabimportGitlabgl=Gitlab(os.environ['GITLAB_HOST'],os.environ['GITLAB_TOKEN'])note=gl.project.get('adamreid/test').issues.get(1).notes.get(1)note.body=note.body.replace('issue:1234','issue:[1234](http://issues.example.com/issue/1234)')note.save()

Enable updates on ProjectIssueNotes

5fe7e27

gpocentek reviewed

May 8, 2016

View reviewed changes

gitlab/objects.py

		@@ -935,7 +935,7 @@ class ProjectHookManager(BaseManager):
		classProjectIssueNote(GitlabObject):
		_url='/projects/%(project_id)s/issues/%(issue_id)s/notes'
		_constructorTypes= {'author':'User'}
		canUpdate=False
		canUpdate=True