Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: allow updating of sub-pages in wikis#1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
kernelport wants to merge1 commit intopython-gitlab:mainfromkernelport:master

Conversation

kernelport
Copy link
Contributor

@kernelportkernelport commentedApr 22, 2020
edited by JohnVillalovos
Loading

Make it possible to update subpages in wikis

Update SaveMixin to use utils._url_encode() on the ID if it is a
string.

Closes:#1079

@max-wittig
Copy link
Member

Hi@kernelport Sorry for the delay! Would you mind to add a quick unit test for this and use conventional changelog for the commit message

@JohnVillalovosJohnVillalovos changed the titlemake it possible to update subpages in wikisfix: allow updating of sub-pages in wikisJan 9, 2022
@codecov-commenter
Copy link

codecov-commenter commentedJan 9, 2022
edited
Loading

Codecov Report

Merging#1080 (535636f) intomain (ac81272) willincrease coverage by0.00%.
The diff coverage is80.00%.

@@           Coverage Diff           @@##             main    #1080   +/-   ##=======================================  Coverage   92.10%   92.11%           =======================================  Files          76       76             Lines        4801     4804    +3     =======================================+ Hits         4422     4425    +3  Misses        379      379
FlagCoverage Δ
cli_func_v481.30% <20.00%> (-0.06%)⬇️
py_func_v480.18% <80.00%> (+0.01%)⬆️
unit83.05% <80.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/mixins.py91.60% <80.00%> (+0.06%)⬆️

Make it possible to update subpages in wikisUpdate SaveMixin to use utils._url_encode() on the ID if it is astring.Closes:python-gitlab#1079
@JohnVillalovos
Copy link
Member

So I'm not sure if this is the way to go. I was thinking maybe we should add aget_url_encoded_id method around here:https://github.com/python-gitlab/python-gitlab/blob/main/gitlab/base.py#L205-L209

@JohnVillalovos
Copy link
Member

Closing this as done by#1819

@nejch
Copy link
Member

@JohnVillalovos I think there might be parts of this that are useful for other issues, see#1081. Notably returning the save results so that moved subpages can be edited. But agreed, the url-encoding is finished.

@JohnVillalovos
Copy link
Member

I'll work on a new PR to return the dictionary fromsave()

@JohnVillalovos
Copy link
Member

I created#1832 for thesave() result.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchAwaiting requested review from nejch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

project.wikis.create with subpages results in 404 Wiki Page Not Found

5 participants

@kernelport@max-wittig@codecov-commenter@JohnVillalovos@nejch

[8]ページ先頭

©2009-2025 Movatter.jp