- Notifications
You must be signed in to change notification settings - Fork676
fix: allow updating of sub-pages in wikis#1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi@kernelport Sorry for the delay! Would you mind to add a quick unit test for this and use conventional changelog for the commit message |
codecov-commenter commentedJan 9, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1080 +/- ##======================================= Coverage 92.10% 92.11% ======================================= Files 76 76 Lines 4801 4804 +3 =======================================+ Hits 4422 4425 +3 Misses 379 379
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Make it possible to update subpages in wikisUpdate SaveMixin to use utils._url_encode() on the ID if it is astring.Closes:python-gitlab#1079
So I'm not sure if this is the way to go. I was thinking maybe we should add a |
Closing this as done by#1819 |
@JohnVillalovos I think there might be parts of this that are useful for other issues, see#1081. Notably returning the save results so that moved subpages can be edited. But agreed, the url-encoding is finished. |
I'll work on a new PR to return the dictionary from |
I created#1832 for the |
Uh oh!
There was an error while loading.Please reload this page.
Make it possible to update subpages in wikis
Update SaveMixin to use utils._url_encode() on the ID if it is a
string.
Closes:#1079