Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: fix comment of prev_page()#1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 3 commits intopython-gitlab:masterfromdonhui:typo-fix
Mar 21, 2020
Merged

Conversation

donhui
Copy link
Contributor

@donhuidonhui commentedMar 18, 2020•
edited
Loading

It shoud beprev, notnext.

@donhuidonhui changed the titletypo fixtypo fix: next --> prevMar 20, 2020
@donhuidonhui changed the titletypo fix: next --> prevdocs: typo fix: next --> prevMar 20, 2020
@donhuidonhui changed the titledocs: typo fix: next --> prevdocs: fix comment of prev_page()Mar 20, 2020
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@donhui, nice catch! And thanks for the commitlint fix :)

I just added 2 small suggestions (sorry for the nitpick). I think we can have the full word in the docs; as is done inhttps://docs.gitlab.com/ee/api/#other-pagination-headers.

donhuiand others added2 commitsMarch 21, 2020 16:02
Co-Authored-By: Nejc Habjan <hab.nejc@gmail.com>
Co-Authored-By: Nejc Habjan <hab.nejc@gmail.com>
@donhui
Copy link
ContributorAuthor

Thank you@donhui, nice catch! And thanks for the commitlint fix :)

I just added 2 small suggestions (sorry for the nitpick). I think we can have the full word in the docs; as is done inhttps://docs.gitlab.com/ee/api/#other-pagination-headers.

Thank you, I have applied your suggestions.

@nejch
Copy link
Member

That was quick, thanks! I've approved but Travis is currently down for maintenance, so we just have to wait for that to go green.

If you find any more inconsistencies, feel free to open a new PR :)

@donhui
Copy link
ContributorAuthor

OK, thanks for your review.

@nejchnejch merged commit82deb7d intopython-gitlab:masterMar 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@donhui@nejch
[8]ページ先頭
©2009-2025 Movatter.jp