Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support for commit revert API (#991)#1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
max-wittig merged 6 commits intopython-gitlab:masterfromnejch:feat/revert-commit-api
Feb 20, 2020
Merged

feat: add support for commit revert API (#991)#1020

max-wittig merged 6 commits intopython-gitlab:masterfromnejch:feat/revert-commit-api
Feb 20, 2020

Conversation

nejch
Copy link
Member

@nejchnejch commentedFeb 18, 2020
edited
Loading

Closes#991.

@nejchnejch closed thisFeb 18, 2020
@nejchnejch reopened thisFeb 18, 2020
@nejch
Copy link
MemberAuthor

Hmm, Travis was failing on something seemingly unrelated in functional tests (https://travis-ci.org/python-gitlab/python-gitlab/jobs/652064210), so I re-opened the PR to trigger it again and now it's happy. ¯\_(ツ)_/¯

@nejchnejch marked this pull request as ready for reviewFebruary 19, 2020 00:04
@nejch
Copy link
MemberAuthor

I was wondering if mayberevert() should return a commit object instead of a dict. It seems like most other update methods also just return the server response but since this creates a new resource, people might want to manipulate that new commit directly - I just didn't see any other examples (cherry_pick doesn't return anything atm).

Copy link
Member

@max-wittigmax-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a small comment. Feel free to ignore it. It's not a big deal.

Thanks for the MR!

@nejchnejch removed their assignmentFeb 19, 2020
@max-wittigmax-wittig merged commite8f0921 intopython-gitlab:masterFeb 20, 2020
@max-wittig
Copy link
Member

Thanks for the MR!

@nejchnejch deleted the feat/revert-commit-api branchFebruary 22, 2020 17:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@max-wittigmax-wittigmax-wittig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to revert a commit of a project
2 participants
@nejch@max-wittig

[8]ページ先頭

©2009-2025 Movatter.jp